Skip to content

Adding on-call team as owner for dependency-related files - #8884

Merged
kachawla merged 7 commits into
radius-project:mainfrom
kachawla:dependabot-approval
Mar 19, 2025
Merged

Adding on-call team as owner for dependency-related files#8884
kachawla merged 7 commits into
radius-project:mainfrom
kachawla:dependabot-approval

Conversation

@kachawla

@kachawla kachawla commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Adding on-call team as owner for dependency-related files to allow them to approve and merge version updates (Dependabot PRs).

Contributor checklist

Please verify that the PR meets the following requirements, where applicable:

  • An overview of proposed schema changes is included in a linked GitHub issue.
    • Yes
    • Not applicable
  • A design document PR is created in the design-notes repository, if new APIs are being introduced.
    • Yes
    • Not applicable
  • The design document has been reviewed and approved by Radius maintainers/approvers.
    • Yes
    • Not applicable
  • A PR for the samples repository is created, if existing samples are affected by the changes in this PR.
    • Yes
    • Not applicable
  • A PR for the documentation repository is created, if the changes in this PR affect the documentation or any user facing updates are made.
    • Yes
    • Not applicable
  • A PR for the recipes repository is created, if existing recipes are affected by the changes in this PR.
    • Yes
    • Not applicable

@kachawla
kachawla requested review from a team as code owners March 17, 2025 19:12
@kachawla
Adding on-call team as owner for dependency-related files
f1765ec 
Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
@kachawla
kachawla force-pushed the dependabot-approval branch from d4a90df to f1765ec Compare March 17, 2025 19:13
@codecov

codecov Bot commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.89%. Comparing base (a513ad5) to head (afd7b7a).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8884      +/-   ##
==========================================
- Coverage   59.89%   59.89%   -0.01%     
==========================================
  Files         595      595              
  Lines       40481    40481              
==========================================
- Hits        24248    24245       -3     
- Misses      14406    14408       +2     
- Partials     1827     1828       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

brooke-hamilton
brooke-hamilton reviewed Mar 17, 2025
View reviewed changes
Comment thread .github/CODEOWNERS Resolved
@kachawla
kachawla temporarily deployed to functional-tests March 17, 2025 21:48 — with GitHub Actions Inactive
@radius-functional-tests

radius-functional-tests Bot commented Mar 17, 2025 •
edited
Loading

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref f1765ec
Unique ID func5beec9d747
Image tag pr-func5beec9d747
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func5beec9d747
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func5beec9d747
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func5beec9d747
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func5beec9d747
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func5beec9d747
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting corerp-cloud functional tests...
⌛ Starting ucp-cloud functional tests...
✅ corerp-cloud functional tests succeeded
✅ ucp-cloud functional tests succeeded

kachawla added 2 commits March 17, 2025 15:28
@kachawla
Add more relevant files
5cc7bfb 
Signed-off-by: Karishma Chawla <kachawla@microsoft.com>
@kachawla
Merge branch 'main' into dependabot-approval
909457b
@kachawla
kachawla temporarily deployed to functional-tests March 18, 2025 00:28 — with GitHub Actions Inactive
@radius-functional-tests

radius-functional-tests Bot commented Mar 18, 2025 •
edited
Loading

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref 909457b
Unique ID func6961decba6
Image tag pr-func6961decba6
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func6961decba6
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func6961decba6
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func6961decba6
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func6961decba6
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func6961decba6
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

brooke-hamilton
brooke-hamilton reviewed Mar 18, 2025
View reviewed changes

@brooke-hamilton brooke-hamilton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While in the on-call role I'm unable to approve this Snyk PR which edits a Dockerfile, so maybe we need to add Dockerfiles as well. What do you think?

@brooke-hamilton brooke-hamilton mentioned this pull request Mar 19, 2025
Closed
4 tasks done
@kachawla
kachawla temporarily deployed to functional-tests March 19, 2025 04:25 — with GitHub Actions Inactive
@radius-functional-tests

radius-functional-tests Bot commented Mar 19, 2025 •
edited
Loading

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref 1b8bc48
Unique ID func0aa3603fa8
Image tag pr-func0aa3603fa8
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func0aa3603fa8
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func0aa3603fa8
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func0aa3603fa8
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func0aa3603fa8
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func0aa3603fa8
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@kachawla
kachawla temporarily deployed to functional-tests March 19, 2025 04:53 — with GitHub Actions Inactive
@radius-functional-tests

radius-functional-tests Bot commented Mar 19, 2025 •
edited
Loading

Copy link
Copy Markdown

Radius functional test overview

🔍 Go to test action run

Name Value
Repository kachawla/radius
Commit ref afd7b7a
Unique ID func30c81788ec
Image tag pr-func30c81788ec
Click here to see the list of tools in the current test run
  • gotestsum 1.12.0
  • KinD: v0.20.0
  • Dapr:
  • Azure KeyVault CSI driver: 1.4.2
  • Azure Workload identity webhook: 1.3.0
  • Bicep recipe location ghcr.io/radius-project/dev/test/testrecipes/test-bicep-recipes/<name>:pr-func30c81788ec
  • Terraform recipe location http://tf-module-server.radius-test-tf-module-server.svc.cluster.local/<name>.zip (in cluster)
  • applications-rp test image location: ghcr.io/radius-project/dev/applications-rp:pr-func30c81788ec
  • dynamic-rp test image location: ghcr.io/radius-project/dev/dynamic-rp:pr-func30c81788ec
  • controller test image location: ghcr.io/radius-project/dev/controller:pr-func30c81788ec
  • ucp test image location: ghcr.io/radius-project/dev/ucpd:pr-func30c81788ec
  • deployment-engine test image location: ghcr.io/radius-project/deployment-engine:latest

Test Status

⌛ Building Radius and pushing container images for functional tests...
✅ Container images build succeeded
⌛ Publishing Bicep Recipes for functional tests...
✅ Recipe publishing succeeded
⌛ Starting ucp-cloud functional tests...
⌛ Starting corerp-cloud functional tests...
✅ ucp-cloud functional tests succeeded
✅ corerp-cloud functional tests succeeded

@kachawla
kachawla merged commit 4912a06 into radius-project:main Mar 19, 2025
@kachawla

kachawla commented Mar 21, 2025

Copy link
Copy Markdown
Member Author

While in the on-call role I'm unable to approve this Snyk PR which edits a Dockerfile, so maybe we need to add Dockerfiles as well. What do you think?

@brooke-hamilton addressed in #8933

@kachawla kachawla mentioned this pull request Mar 24, 2025
Merged
6 of 12 tasks
@kachawla
kachawla deleted the dependabot-approval branch March 24, 2025 23:09
kachawla added a commit that referenced this pull request Mar 26, 2025
@kachawla
Update codeowners: Remove oncall team from github workflows (#8955)
e442fb4 
# Description

I recently added on-call group as owner for a few dependency related
files to allow on-call to handle depedenabot/snyk PRs:
#8884. However, looking at
the list again, I realized that github workflows have a lot of core
functionality and are generally not limited to version updates, so
removing on-call team from the codeowners list for github workflows.

Signed-off-by: Karishma Chawla <kachawla@microsoft.com>

This branch was previously deployed

2 inactive deployments
functional-tests — afd7b7a1 Deployed Mar 19, 2025 by kachawla
publish-bicep — afd7b7a1 Deployed Mar 19, 2025 by kachawla
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brooke-hamilton brooke-hamilton brooke-hamilton approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kachawla @brooke-hamilton